Home Original page

Make tests more clear by jennabelle · Pull Request #8999 · nodejs/node

added 2 commits

September 24, 2016 20:44

Jenna Vuong and others added 2 commits

October 9, 2016 22:33

@jennabelle

@mscdex mscdex added the fs

Issues and PRs related to the fs subsystem / file system.

label

Oct 10, 2016

@jennabelle 

Add `assert.strictEqual(err.code, 'ENOENT')` and changed the last `var` to `const` for clarity
Refactor line 79 to use `includes()` instead of `indexOf() >= 0` for better readability. Change `var` to `const` for clarity

Trott pushed a commit to Trott/io.js that referenced this pull request

Oct 13, 2016 
* var to const
* add check that expected error is ENOENT
* indexOf() to includes()

PR-URL: nodejs#8999
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

jasnell pushed a commit that referenced this pull request

Oct 14, 2016 
* var to const
* add check that expected error is ENOENT
* indexOf() to includes()

PR-URL: #8999
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 11, 2016 
* var to const
* add check that expected error is ENOENT
* indexOf() to includes()

PR-URL: #8999
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>