Home Original page

lib,test: remove unneeded escaping of / by Trott · Pull Request #9485 · nodejs/node

@Trott added test

Issues and PRs related to the tests.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Nov 6, 2016

@nodejs-github-bot nodejs-github-bot added fs

Issues and PRs related to the fs subsystem / file system.

url

Issues and PRs related to the legacy built-in url module.

labels

Nov 6, 2016

princejwesley

not-an-aardvark

@Trott 

The `/` character does not need to be escaped when occurring inside a
character class in a regular expression. Remove such instances of
escaping in the code base.

@Trott Trott changed the title lib,test: remove unneeded escaping of /` lib,test: remove unneeded escaping of /

Nov 6, 2016

silverwind

Trott added a commit to Trott/io.js that referenced this pull request

Nov 10, 2016 
The `/` character does not need to be escaped when occurring inside a
character class in a regular expression. Remove such instances of
escaping in the code base.

PR-URL: nodejs#9485
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

addaleax pushed a commit that referenced this pull request

Nov 22, 2016 
The `/` character does not need to be escaped when occurring inside a
character class in a regular expression. Remove such instances of
escaping in the code base.

PR-URL: #9485
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

addaleax pushed a commit to addaleax/node that referenced this pull request

Dec 8, 2016 
The `/` character does not need to be escaped when occurring inside a
character class in a regular expression. Remove such instances of
escaping in the code base.

PR-URL: nodejs#9485
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
The `/` character does not need to be escaped when occurring inside a
character class in a regular expression. Remove such instances of
escaping in the code base.

PR-URL: #9485
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

@Trott Trott deleted the slash-escape branch

January 13, 2022 22:44