Home Original page

fs: make sure readFile[Sync] reads from the beginning by seishun · Pull Request #9699 · nodejs/node

@nodejs-github-bot added the fs

Issues and PRs related to the fs subsystem / file system.

label

Nov 19, 2016

@jasnell jasnell added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Dec 5, 2016

@seishun

@seishun

cjihrig

@seishun

@seishun

bnoordhuis

@seishun

bnoordhuis

@seishun

bnoordhuis

@seishun seishun removed the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jan 8, 2017

sam-github

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 18, 2017 
It would previously read from the current file position, which can be
non-zero if the `fd` has been read from or written to. This contradicts
the documentation which states that it "reads the entire contents of a
file".

PR-URL: nodejs#9699
Fixes: nodejs#9671
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

italoacasas pushed a commit to italoacasas/node that referenced this pull request

Jan 23, 2017 
It would previously read from the current file position, which can be
non-zero if the `fd` has been read from or written to. This contradicts
the documentation which states that it "reads the entire contents of a
file".

PR-URL: nodejs#9699
Fixes: nodejs#9671
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>