Home Original page

v4: fix building v8 on libc++ 3.8.0 by jbergstroem · Pull Request #9763 · nodejs/node

@jbergstroem added v4.x v8 engine

Issues and PRs related to the V8 dependency.

labels

Nov 23, 2016

bnoordhuis

MylesBorins

ofrobots

@jbergstroem @MylesBorins 

Make sure the map allocators are of the same type. This fixes
building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).

Upstream bug/patch: https://bugs.freebsd.org/208467

MylesBorins pushed a commit that referenced this pull request

Dec 1, 2016 
Make sure the map allocators are of the same type. This fixes
building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).

Upstream bug/patch: https://bugs.freebsd.org/208467

PR-URL: #9763
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request

Dec 7, 2016 
Make sure the map allocators are of the same type. This fixes
building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).

Upstream bug/patch: https://bugs.freebsd.org/208467

PR-URL: nodejs/node#9763
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>