Home Original page

test: fix flaky test-cluster-dgram-2 by Trott · Pull Request #9791 · nodejs/node

@Trott 

There is no guarantee that a dgram packet will be received. The test is
currently written to only send exactly as many dgram packets as required
assuming they are all received. As a result, failures like this may
occur (from CI):

```
not ok 719 parallel/test-cluster-dgram-2
  ---
  duration_ms: 120.39
  severity: fail
  stack: |-
    timeout
```

This change has the workers send packets continuously until disconnect.

Ref: https://ci.nodejs.org/job/node-test-commit-arm/6044/nodes=armv7-ubuntu1404/console

@Trott added cluster

Issues and PRs related to the cluster subsystem.

test

Issues and PRs related to the tests.

labels

Nov 24, 2016

@Trott Trott mentioned this pull request

Nov 24, 2016

2 tasks

@mscdex mscdex added the dgram

Issues and PRs related to the dgram subsystem / UDP.

label

Nov 24, 2016

santigimeno

Trott added a commit to Trott/io.js that referenced this pull request

Nov 28, 2016 
There is no guarantee that a dgram packet will be received. The test is
currently written to only send exactly as many dgram packets as required
assuming they are all received. As a result, failures like this may
occur (from CI):

```
not ok 719 parallel/test-cluster-dgram-2
  ---
  duration_ms: 120.39
  severity: fail
  stack: |-
    timeout
```

This change has the workers send packets continuously until disconnect.

PR-URL: nodejs#9791
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

addaleax pushed a commit that referenced this pull request

Dec 5, 2016 
There is no guarantee that a dgram packet will be received. The test is
currently written to only send exactly as many dgram packets as required
assuming they are all received. As a result, failures like this may
occur (from CI):

```
not ok 719 parallel/test-cluster-dgram-2
  ---
  duration_ms: 120.39
  severity: fail
  stack: |-
    timeout
```

This change has the workers send packets continuously until disconnect.

PR-URL: #9791
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

addaleax pushed a commit to addaleax/node that referenced this pull request

Dec 8, 2016 
There is no guarantee that a dgram packet will be received. The test is
currently written to only send exactly as many dgram packets as required
assuming they are all received. As a result, failures like this may
occur (from CI):

```
not ok 719 parallel/test-cluster-dgram-2
  ---
  duration_ms: 120.39
  severity: fail
  stack: |-
    timeout
```

This change has the workers send packets continuously until disconnect.

PR-URL: nodejs#9791
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
There is no guarantee that a dgram packet will be received. The test is
currently written to only send exactly as many dgram packets as required
assuming they are all received. As a result, failures like this may
occur (from CI):

```
not ok 719 parallel/test-cluster-dgram-2
  ---
  duration_ms: 120.39
  severity: fail
  stack: |-
    timeout
```

This change has the workers send packets continuously until disconnect.

PR-URL: #9791
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

@Trott Trott deleted the de-flake-dgram branch

January 13, 2022 22:44