repl: fix generator function preprocessing by not-an-aardvark · Pull Request #9852 · nodejs/node
Function declarations in the REPL are preprocessed into variable declarations before being evaluated. However, the preprocessing logic did not account for the star in a generator function declaration, which caused the preprocessor to output invalid syntax in some circumstances. PR-URL: nodejs#9852 Fixes: nodejs#9850 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this pull request
Dec 5, 2016Function declarations in the REPL are preprocessed into variable declarations before being evaluated. However, the preprocessing logic did not account for the star in a generator function declaration, which caused the preprocessor to output invalid syntax in some circumstances. PR-URL: #9852 Fixes: #9850 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Fishrock123 added a commit that referenced this pull request
Dec 6, 2016Notable changes: * buffer: - Reverted the runtime deprecation of calling `Buffer()` without `new`. (Anna Henningsen) #9529 - Fixed `buffer.transcode()` for single-byte character encodings to `UCS2`. (Anna Henningsen) #9838 * promise: `--trace-warnings` now produces useful stacktraces for Promise warnings. (Anna Henningsen) #9525 * repl: Fixed a bug preventing correct parsing of generator functions. (Teddy Katz) #9852 * V8: Fixed a significant `instanceof` performance regression. (Franziska Hinkelmann) #9730 PR-URL: #10127
imyller added a commit to imyller/meta-nodejs that referenced this pull request
Dec 7, 2016 Notable changes:
* buffer:
- Reverted the runtime deprecation of calling `Buffer()` without
`new`. (Anna Henningsen) nodejs/node#9529
- Fixed `buffer.transcode()` for single-byte character
encodings to `UCS2`. (Anna Henningsen)
nodejs/node#9838
* promise: `--trace-warnings` now produces useful stacktraces for
Promise warnings. (Anna Henningsen)
nodejs/node#9525
* repl: Fixed a bug preventing correct parsing of generator functions.
(Teddy Katz) nodejs/node#9852
* V8: Fixed a significant `instanceof` performance regression.
(Franziska Hinkelmann) nodejs/node#9730
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request
Dec 8, 2016Function declarations in the REPL are preprocessed into variable declarations before being evaluated. However, the preprocessing logic did not account for the star in a generator function declaration, which caused the preprocessor to output invalid syntax in some circumstances. PR-URL: nodejs#9852 Fixes: nodejs#9850 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request
Dec 20, 2016Function declarations in the REPL are preprocessed into variable declarations before being evaluated. However, the preprocessing logic did not account for the star in a generator function declaration, which caused the preprocessor to output invalid syntax in some circumstances. PR-URL: #9852 Fixes: #9850 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request
Dec 21, 2016Function declarations in the REPL are preprocessed into variable declarations before being evaluated. However, the preprocessing logic did not account for the star in a generator function declaration, which caused the preprocessor to output invalid syntax in some circumstances. PR-URL: #9852 Fixes: #9850 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit that referenced this pull request
Jan 3, 2017This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) #9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) #9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) #8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) #10103
- improved support for generator functions (Teddy Katz)
#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) #9685
PR-URL: #10394
MylesBorins added a commit that referenced this pull request
Jan 3, 2017This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) #9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) #9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) #8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) #10103
- improved support for generator functions (Teddy Katz)
#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) #9685
PR-URL: #10394
imyller added a commit to imyller/meta-nodejs that referenced this pull request
Mar 2, 2017 This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) nodejs/node#9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
nodejs/node#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
nodejs/node#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) nodejs/node#9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) nodejs/node#8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
nodejs/node#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) nodejs/node#10103
- improved support for generator functions (Teddy Katz)
nodejs/node#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) nodejs/node#9685
PR-URL: nodejs/node#10394
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request
Mar 2, 2017 This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) nodejs/node#9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
nodejs/node#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
nodejs/node#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) nodejs/node#9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) nodejs/node#8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
nodejs/node#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) nodejs/node#10103
- improved support for generator functions (Teddy Katz)
nodejs/node#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) nodejs/node#9685
PR-URL: nodejs/node#10394
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters