Home Original page

test: refactor test-tls-timeout-server-2 by drifkin · Pull Request #9876 · nodejs/node

@drifkin 

* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Dec 1, 2016

drifkin

cjihrig

@mscdex mscdex added the tls

Issues and PRs related to the tls subsystem.

label

Dec 1, 2016

@imyller imyller added the code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

label

Dec 1, 2016

@drifkin 

The `common.mustCall` isn’t necessary, since the test will fail from
timing out if the callback is never called.

addaleax

jasnell pushed a commit that referenced this pull request

Dec 4, 2016 
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`

PR-URL: #9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit that referenced this pull request

Dec 5, 2016 
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`

PR-URL: #9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit to addaleax/node that referenced this pull request

Dec 8, 2016 
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`

PR-URL: nodejs#9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

jmdarling pushed a commit to jmdarling/node that referenced this pull request

Dec 8, 2016 
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`

PR-URL: nodejs#9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 20, 2016 
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`

PR-URL: #9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`

PR-URL: #9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`

PR-URL: #9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Dec 21, 2016