Home Original page

test: edited assertion and timeout for test by danielgsims · Pull Request #9889 · nodejs/node

In this change, the setTimeout needed a second argument, so I set that
value to 0. In addition, I changed the assertion to be a strictEquals
instead of equals.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Dec 1, 2016

@mscdex mscdex added the domain

Issues and PRs related to the domain subsystem.

label

Dec 1, 2016

cjihrig

@imyller imyller added the code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

label

Dec 1, 2016

lpinca

I changed the var declarations to const in this unit test

Trott pushed a commit to Trott/io.js that referenced this pull request

Dec 7, 2016 
In this change, the setTimeout needed a second argument, so I set that
value to 1. In addition, I changed the assertion to be a strictEquals
instead of equals.

I changed the var declarations to const in this test.

PR-URL: nodejs#9889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax pushed a commit that referenced this pull request

Dec 8, 2016 
In this change, the setTimeout needed a second argument, so I set that
value to 1. In addition, I changed the assertion to be a strictEquals
instead of equals.

I changed the var declarations to const in this test.

PR-URL: #9889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax pushed a commit to addaleax/node that referenced this pull request

Dec 8, 2016 
In this change, the setTimeout needed a second argument, so I set that
value to 1. In addition, I changed the assertion to be a strictEquals
instead of equals.

I changed the var declarations to const in this test.

PR-URL: nodejs#9889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 20, 2016 
In this change, the setTimeout needed a second argument, so I set that
value to 1. In addition, I changed the assertion to be a strictEquals
instead of equals.

I changed the var declarations to const in this test.

PR-URL: #9889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
In this change, the setTimeout needed a second argument, so I set that
value to 1. In addition, I changed the assertion to be a strictEquals
instead of equals.

I changed the var declarations to const in this test.

PR-URL: #9889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
In this change, the setTimeout needed a second argument, so I set that
value to 1. In addition, I changed the assertion to be a strictEquals
instead of equals.

I changed the var declarations to const in this test.

PR-URL: #9889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This was referenced

Dec 21, 2016