Home Original page

update test/parallel/test-fs-read-stream-inherit.js to use ES6 variable declarations and assert.strictEqual by jmdarling · Pull Request #9894 · nodejs/node

added 2 commits

December 1, 2016 10:13
converts all instances of 'var' to const / let
converts instances of assert.equal to assert.strictEqual

@mscdex mscdex added the fs

Issues and PRs related to the fs subsystem / file system.

label

Dec 1, 2016

@imyller imyller added the code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

label

Dec 1, 2016

cjihrig

lpinca

Jonathan Darling added 2 commits

December 3, 2016 11:56
Removes an assert that has been commented out.
Fixes the parameter order to some calls of assert.strictEqual to
be consistent with documentation and the rest of the file.

lpinca

lpinca

lpinca

Fixes spacing that become improperly alligned after changing var
declarations to const.

jasnell pushed a commit that referenced this pull request

Dec 4, 2016 
* convert assert.equal to assert.strictEqual
* convert var to const/let

PR-URL: #9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit that referenced this pull request

Dec 5, 2016 
* convert assert.equal to assert.strictEqual
* convert var to const/let

PR-URL: #9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit to addaleax/node that referenced this pull request

Dec 8, 2016 
* convert assert.equal to assert.strictEqual
* convert var to const/let

PR-URL: nodejs#9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jmdarling pushed a commit to jmdarling/node that referenced this pull request

Dec 8, 2016 
* convert assert.equal to assert.strictEqual
* convert var to const/let

PR-URL: nodejs#9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 20, 2016 
* convert assert.equal to assert.strictEqual
* convert var to const/let

PR-URL: #9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
* convert assert.equal to assert.strictEqual
* convert var to const/let

PR-URL: #9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2016 
* convert assert.equal to assert.strictEqual
* convert var to const/let

PR-URL: #9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Dec 21, 2016