napi-asyncworker-example missing scope
Navigation Menu
{{ message }}
nodejs / node-addon-examples Public
- Notifications You must be signed in to change notification settings
- Fork 602
Closed
Closed
Description
opened
on Jun 13, 2020node-addon-examples/napi-asyncworker-example/node-addon-api/src/SimpleAsyncWorker.cc
Lines 13 to 16 in dc86a66
| void SimpleAsyncWorker::OnOK() { | |
| std::string msg = "SimpleAsyncWorker returning after 'working' " + std::to_string(runTime) + " seconds."; | |
| Callback().Call({Env().Null(), String::New(Env(), msg)}); | |
| }; |
This seems to be the only example that doesn't call:
Napi::HandleScope scope(Env());
Should this example include that too?
Metadata
Metadata
Assignees
No one assigned
Labels
No labels
No labels
Type
No type
Projects
No projects
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions