chore: remove mastodon logos by skyeyeye ยท Pull Request #8649 ยท nodejs/nodejs.org
Description
Closes #7873
Validation
Related Issues
Check List
- I have read the Contributing Guidelines and made commit messages that follow the guideline.
- I have run
pnpm formatto ensure the code follows the style guide. - I have run
pnpm testto check if all tests are passing. - I have run
pnpm buildto check if the website builds without errors. - I've covered new added functionality with unit tests if necessary.
๐ Codeowner Review Request
The following codeowners have been identified for the changed files:
Team reviewers: @nodejs/nodejs-website
Please review the changes when you have a chance. Thank you! ๐
@skyeyeye you've opened SEVERAL pull requests. Please stop, each one alerts our team.
Please do any and all changes in this PR, and only this PR. Subsequently superfluous changes will be considered spam.
Iโm unable to access the Vercel preview logs due to permission restrictions. The project builds successfully locally (pnpm build). Could you please share the specific failure reason?
Codecov Report
โ
All modified and coverable lines are covered by tests.
โ
Project coverage is 75.06%. Comparing base (2bb1883) to head (a1b53e2).
โ
All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@ ## main #8649 +/- ## ========================================== - Coverage 75.13% 75.06% -0.07% ========================================== Files 104 104 Lines 9098 9093 -5 Branches 314 315 +1 ========================================== - Hits 6836 6826 -10 - Misses 2260 2265 +5 Partials 2 2
โ View full report in Codecov by Sentry.
๐ข Have feedback on the report? Share it here.
avivkeller
changed the title
mastodon removed
chore: remove mastodon logos
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a lot of things got messed up. You should just have to revert your last commit and run pnpm format
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting a block on this, not for an issue with the change itself, but because we need to make sure messaging goes out on the account before we land this and call the issue closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters