TST: marks on a fixture have no effect by mattip · Pull Request #25710 · numpy/numpy

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mattip

Copy link Copy Markdown

Member

@mattip mattip commented

Jan 27, 2024

Apparently applying a mark to a fixture is a no-op and has emitted a deprecation warning on pytest>=7.4. With pytest-8.0 collection is failing. The new version was released just a little while ago.

I wonder why we did not see this warning before it became a failure. xref #25503

@charris charris added the 09 - Backport-Candidate

PRs tagged should be backported

label

Jan 28, 2024

@charris charris merged commit 4001f26 into numpy:main

Jan 28, 2024

@charris

Copy link Copy Markdown

Member

charris commented

Jan 28, 2024

Thanks Matti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattip @charris