Home Original page

BUG: Include python-including headers first by DWesl · Pull Request #29281 · numpy/numpy

@DWesl

mattip

mattip previously approved these changes Jun 29, 2025

ngoldbaum

@DWesl 

…why it should be there."

This reverts commit 83c46c9.
…why it's there."

This reverts commit 79ab767.

@DWesl

@DWesl

@DWesl

DWesl

@DWesl 

Not whichever was last included

tylerjereddy

@DWesl 

Also allow passing a specific directory.

@DWesl

ngoldbaum

@DWesl

@DWesl

charris pushed a commit to charris/numpy that referenced this pull request

Sep 22, 2025 
Makes sure that Python headers always come first (if implicitly)

Also adds a script to check this and a CI run to ensure this.

NOTE(seberg): If that script/CI run becomes problematic and not super easy to fix maybe we shouldn't worry too much about even deleting it again. It's wortwhile for sure, but I am not sure it is worthwhile to spend too many cycles making pretty.

charris added a commit that referenced this pull request

Sep 22, 2025 
BUG: Include python-including headers first (#29281)

IndifferentArea pushed a commit to IndifferentArea/numpy that referenced this pull request

Dec 7, 2025 
Makes sure that Python headers always come first (if implicitly)

Also adds a script to check this and a CI run to ensure this.

NOTE(seberg): If that script/CI run becomes problematic and not super easy to fix maybe we shouldn't worry too much about even deleting it again. It's wortwhile for sure, but I am not sure it is worthwhile to spend too many cycles making pretty.