Home Original page

BUG: Fixes #7395, operator.index now fails on numpy.bool_ by emilienkofman · Pull Request #7420 · numpy/numpy

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@emilienkofman

Copy link

Contributor

Attempt to fix the bug described in #7395. If this needs a depreciation warning I can change the Err to Warning and maybe add a test (?)

@charris

Copy link

Member

charris commented

Mar 18, 2016

Needs a test in anycase, also a mention in doc/release/1.12.0-notes.rst.

@charris charris added the 56 - Needs Release Note.

Needs an entry in doc/release/upcoming_changes

label

Mar 18, 2016

@seberg

Copy link

Member

seberg commented

Mar 30, 2016

Should we deprecate this first if we do it? Once this is removed PyArray_IntpFromPyInt (or whatever it was exactly called) in conversion_utils.c can be simplified a little, since checking for a numpy bool is not necessary anymore.

@charris charris added this to the 1.12.0 release milestone

Apr 16, 2016

@charris charris removed this from the 1.12.0 release milestone

Jun 14, 2016

@charris

Copy link

Member

charris commented

Jun 14, 2016

@emilienkofman Needs to be finished.

@eric-wieser

Copy link

Member

eric-wieser commented

Sep 14, 2017

•

edited

Loading

Closing in favor of the rebase, #9685 - I wasn't able to push over your branch here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

00 - Bug 56 - Needs Release Note.

Needs an entry in doc/release/upcoming_changes

component: numpy._core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emilienkofman @charris @seberg @eric-wieser