fix(deps): use updated import path for `github.com/speakeasy-api/openapi/overlay` by netixx · Pull Request #2231 · oapi-codegen/oapi-codegen
jamietanna
changed the title
Fix import path for overlay pkg
fix(deps): use updated import path for github.com/speakeasy-api/openapi/overlay
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛑 we don't want to bump this high
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why? Even Go 1.24 is not supported anymore since Go 1.26 was released.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so this looks like this may also involve bumping #2139 (and our go directive), which we try hard to avoid - we'll have to think about this
I think we need to talk about the required Go version. I originally tried to keep the oldest version possible, but the most important part to me is that the generated code isn't too version specific.
I think that jumping to 1.24 would allow us to move to the new usage of go tool have only one way of using and installing oapi-codegen. Being 1.22 based forces us to use very old versions of some dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters