Fix: Query param deepObject return without assign on !required by voro015 · Pull Request #68 · oapi-codegen/runtime
Navigation Menu
{{ message }}
oapi-codegen / runtime Public
- Notifications You must be signed in to change notification settings
- Fork 47
Merged
mromaszewicz merged 3 commits intooapi-codegen:mainfrom
Mar 18, 2026Merged
Conversation
Copy link
Contributor
voro015
commented
May 7, 2025
voro015
commented
Updated BindQueryParameter to return error if query param was not provided but was set as required
Updated UnmarshalDeepObject to skip value assign if query param was not provided and not required
Fixes #67
voro015
requested a review
from a team
as a code owner
Copy link
artemvoroninepg
commented
Feb 6, 2026
artemvoroninepg commented
Feb 6, 2026@jamietanna sorry for a direct ping, it's been almost a year, may I ask for your review?
Exercise the required and optional code paths for deepObject-style query parameters to verify no unintended side effects from PR oapi-codegen#68. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mromaszewicz approved these changes Mar 18, 2026
Copy link
Member
mromaszewicz
commented
Mar 18, 2026
mromaszewicz commented
Mar 18, 2026Thanks for doing this, and sorry about the long delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment