Fix linter errors by mromaszewicz · Pull Request #85 · oapi-codegen/runtime
Navigation Menu
{{ message }}
oapi-codegen / runtime Public
- Notifications You must be signed in to change notification settings
- Fork 47
Merged
Conversation
Copy link
Member
mromaszewicz
commented
Oct 30, 2025
mromaszewicz
commented
We have some old code which started to fail lint due to the linter being pedantic. Fix lint issues.
We have some old code which started to fail lint due to the linter being pedantic. Fix lint issues.
mromaszewicz
requested a review
from a team
as a code owner
jamietanna approved these changes Oct 30, 2025
Copy link
Member
jamietanna
left a comment
jamietanna
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these changes not picked up on by CI?
Copy link
Member Author
They were not. The code around calling functions on embedded struct hasn't changed in ages.
mromaszewicz
deleted the
lint
branch
Copy link
Member
jamietanna
commented
Oct 30, 2025
jamietanna commented
Oct 30, 2025It looks like it's because we'd not approved the CI from the first-time contribution in #72 so no CI checks ran - if they had, we'd have had a failing PR build before it landed on main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants