Make it easier to use `testutil` with other test frameworks by accepting an `interface`, not a `testing.T` by dzakaammar · Pull Request #6 · oapi-codegen/testutil

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@dzakaammar

Copy link

Contributor

declare and use TestReporter interface instead of using *testing.T directly to make the function compatible for other testing framework like Ginkgo

@dzakaammar dzakaammar changed the title declare TestReporter interface declare and use TestReporter interface

Nov 12, 2023

@jamietanna jamietanna added the enhancement

New feature or request

label

Nov 14, 2023

@jamietanna jamietanna changed the title declare and use TestReporter interface Make it easier to use testutil with other test frameworks by accepting an interface, not a testing.T

Nov 14, 2023
Copy link

Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

dzakaammar reacted with thumbs up emoji

@jamietanna jamietanna merged commit e39e1d4 into oapi-codegen:main

Nov 14, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamietanna jamietanna jamietanna approved these changes

Assignees

No one assigned

Labels

enhancement

New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dzakaammar @jamietanna @dzekatmekari