feat: add 'opentelemetry-exporter-otlp-json-common' package by herin049 · Pull Request #4996 · open-telemetry/opentelemetry-python
Conversation
Description
Follow up to #4910 to progress towards adding support for OTLP JSON.
Fixes #1003
Type of change
Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
tox -e py314-test-opentelemetry-exporter-otlp-json-common
Does This PR Require a Contrib Repo Change?
- Yes. - Link to PR:
- No.
Checklist:
- Followed the style guidelines of this project
- Changelogs have been updated
- Unit tests have been added
- Documentation has been updated
herin049
marked this pull request as ready for review
Thanks for this and the benchmarks! I like how it's laid out very similarly to the otlp-proto-common.
removal of ~200 lines of Windows getting-started and opentracing-shim jobs from test_0.yml
I believe they were moved to test_1.yml
Thanks for this and the benchmarks! I like how it's laid out very similarly to the otlp-proto-common.
removal of ~200 lines of Windows getting-started and opentracing-shim jobs from test_0.yml
I believe they were moved to test_1.yml
That was my goal, although I made a few alterations/simplifications.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, would be great if others from the discussion to have a look too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters