Home Original page

add Samsung S4 mini (serranolte) by freechelmi · Pull Request #134 · openandroidinstaller-dev/openandroidinstaller

@freechelmi

serranolte and serranoltexx supported

@freechelmi

@tsterbak tsterbak added the device

Request to add or improve a specific device.

label

Mar 31, 2023

@tsterbak

Looks good! :) Could you add the device also to the README?

@tsterbak

@freechelmi

@freechelmi

Readme for serranoltexx added , I'm not sure about 3G variants , we can test and add them later on

@freechelmi

@MagicLike

@tsterbak Are two configs for the same device codes necessary?

MagicLike

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing slash at the end of the wiki link. All the others will be removed when #129 gets merged...

@freechelmi

@tsterbak tsterbak changed the base branch from main to dev

April 3, 2023 13:14

@tsterbak

@tsterbak Are two configs for the same device codes necessary?

I guess, having only the serranoltexx config with support for both codes should be fine. If possible only one should exist.

@freechelmi do you think this is possible? Then I would resolve the conflict in the readme and merge it. :)

@freechelmi

Done , Yes if you can resolve the conflict :-)

@MagicLike

Done , Yes if you can resolve the conflict :-)

One thing: please remove the trailing slash as stated in my review. Would it also be possible to move every text of content into its own line using the > as shown in line 13 of your config to ensure consistency?