filter plugin for tags was not working as expected. Regex expression to check for white space needed to be changed. by gbone24 · Pull Request #256 · openannotation/annotator
Navigation Menu
{{ message }}
openannotation / annotator Public
- Notifications You must be signed in to change notification settings
- Fork 539
Merged
nickstenning merged 1 commit intoopenannotation:masterfrom
gbone24:bug-fix
nickstenning merged 1 commit intoopenannotation:masterfrom
gbone24:bug-fix
Conversation
Copy link
Contributor
gbone24
commented
Aug 19, 2013
gbone24
commented
input.split /\s*/ was not producing the desired result. It was taking the filter input for tags and looking for each letter instead of the word. changing regex to /\s+/ seemed to fix things.
…d to \s+ which does a better job at dealing with whitespace between tags.
Copy link
Member
nickstenning
commented
Aug 20, 2013
nickstenning commented
Aug 20, 2013That's clearly correct =). Thanks!
nickstenning added a commit that referenced this pull request
Aug 20, 2013filter plugin for tags was not working as expected. Regex expression to check for white space needed to be changed.
nickstenning
merged commit
48fe939
into
openannotation:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants