fix: urllib3 compatibility < v2 by evansims · Pull Request #179 · openfga/python-sdk
Navigation Menu
{{ message }}
openfga / python-sdk Public
- Notifications You must be signed in to change notification settings
- Fork 34
Merged
Conversation
Copy link
Contributor
evansims
commented
Mar 26, 2025
evansims
commented
Description
- Bumped dependency requirements for
urllib3to specify >= v1.26.19 or >= v2.2.2 - Modified type hints in
RESTResponseclass to useurllib3.HTTPResponseinstead ofurllib3.BaseHTTPResponse - Added matrix testing for different urllib3 versions in GitHub Actions workflow
References
Review Checklist
- I have clicked on "allow edits by maintainers".
- I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
- The correct base branch is being used, if not
main - I have added tests to validate that the change in functionality is working as expected
Copy link
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 70.42%. Comparing base (
e07ce96) to head (358f7a7).
❌ Your project status has failed because the head coverage (70.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@ ## main #179 +/- ## ======================================= Coverage 70.42% 70.42% ======================================= Files 134 134 Lines 10798 10798 ======================================= Hits 7605 7605 Misses 3193 3193
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
evansims
force-pushed
the
fix/python/replace-basehttpresponse
branch
from
6294888 to
17378ee
Compare
evansims
marked this pull request as ready for review
evansims
requested a review
from a team
as a code owner
evansims
force-pushed
the
fix/python/replace-basehttpresponse
branch
from
17378ee to
358f7a7
Compare
rhamzeh approved these changes Mar 26, 2025
evansims
added this pull request to the merge queue
evansims
deleted the
fix/python/replace-basehttpresponse
branch
evansims
mentioned this pull request
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment