[#2474] Add extra sanity checks for small or zero-area fins in aerodynamics calculations by SiboVG · Pull Request #2633 · openrocket/openrocket

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@SiboVG

Copy link

Member

@SiboVG SiboVG commented

Dec 24, 2024

This PR fixes #2474 by adding extra sanity checks in FinSetCalc for when the fin area/MAC span is zero or very small. See also this comment.

@SiboVG SiboVG changed the title [#2474] Add extra checks for zero-area fins [#2474] Add extra sanity checks for zero-area fins in aerodynamics calculations

Dec 24, 2024

@SiboVG SiboVG changed the title [#2474] Add extra sanity checks for zero-area fins in aerodynamics calculations [#2474] Add extra sanity checks for small or zero-area fins in aerodynamics calculations

Dec 24, 2024

@SiboVG SiboVG merged commit d2b7638 into openrocket:unstable

Jan 9, 2025

@SiboVG SiboVG deleted the issue-2474 branch

January 9, 2025 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.01" tall fins break the CP calculation

1 participant

@SiboVG