Home Original page

OSD-28717: Fix build failures of backplane-cli while bumping to version 1.23 by Dee-6777 · Pull Request #636 · openshift/backplane-cli

@Dee-6777

@Dee-6777 Dee-6777 commented

Mar 17, 2025

•

edited by openshift-ci bot

Loading

What type of PR is this?

bug

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Resolves #OSD-28717

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@Dee-6777

@openshift-ci-robot

@Dee-6777: This pull request references OSD-28717 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What type of PR is this?

bug

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Resolves #OSD-28717

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment

@openshift-ci-robot

@Dee-6777: This pull request references OSD-28717 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What type of PR is this?

bug

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Resolves #OSD-28717

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dee-6777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved

Indicates a PR has been approved by an approver from all required OWNERS files.

label

Mar 17, 2025

@Dee-6777

1 similar comment

@Dee-6777

@Dee-6777

@openshift-ci

@Dee-6777: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/coverage bdbb10f link true /test coverage
ci/prow/test bdbb10f link true /test test
ci/prow/lint bdbb10f link true /test lint
ci/prow/build bdbb10f link true /test build
ci/prow/images bdbb10f link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

samanthajayasinghe

RUN go env -w GOTOOLCHAIN=go1.22.7+auto
# Configure the env
ENV PATH="/root/sdk/go1.23.7/bin:${PATH}"
RUN go1.23.7 env -w GOTOOLCHAIN=go1.23.7+auto

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right , it should be

RUN go env -w GOTOOLCHAIN=go1.23.7+auto
RUN yum install --assumeyes \
make \
git \
go-toolset

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't remove go-toolset from base image .