fix: grammar issue by metacosm · Pull Request #3083 · operator-framework/java-operator-sdk
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update also the docs.
metacosm
changed the title
fix: typos
fix: grammar issue
There is one more here:
@ControllerConfiguration(triggerReconcilerOnAllEvent = true)
I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1.
There is one more here:
@ControllerConfiguration(triggerReconcilerOnAllEvent = true) I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1.
I think we should do it also, but I can do it as separate PR if you see it better that way, just to don't make confusion around it if some reads the blog.
There is one more here:
@ControllerConfiguration(triggerReconcilerOnAllEvent = true) I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1.
I think we should do it also, but I can do it as separate PR if you see it better that way, just to don't make confusion around it if some reads the blog.
If we agree that the blog should be modified, I can do it here.
There is one more here:
@ControllerConfiguration(triggerReconcilerOnAllEvent = true) I was about to change these as well (there's another one in that file as well, iirc) but since it's part of the blog, I decided against changing it but we should indeed mention it in the release notes and/or blog for 5.2.1.
I think we should do it also, but I can do it as separate PR if you see it better that way, just to don't make confusion around it if some reads the blog.
If we agree that the blog should be modified, I can do it here.
I would vote for that, thx!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters