Home Original page

🐛 catalogd: e2e metrics: Do not use a fixed namespace for metrics tests by camilamacedo86 · Pull Request #1561 · operator-framework/operator-controller

@camilamacedo86

Follow op-con's lead on specifying a metrics address

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 

Follow op-con's lead on specifying a metrics address

Signed-off-by: Todd Short <todd.short@me.com>

@netlify

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (75bb73e) to head (04eca0b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1561   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files          57       57           
  Lines        4584     4584           
=======================================
  Hits         3057     3057           
  Misses       1302     1302           
  Partials      225      225
Flag Coverage Δ
e2e 52.72% <ø> (ø)
unit 53.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LalatenduMohanty
t.Log("Validating the metrics endpoint")
metricsURL := "https://catalogd-service.olmv1-system.svc.cluster.local:7443/metrics"
metricsURL := "https://catalogd-service." + namespace + ".svc.cluster.local:7443/metrics"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LalatenduMohanty

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks

Jan 9, 2025