🐛 fix install script and release to use and provide default-catalog by camilamacedo86 · Pull Request #1675

🐛 fix install script and release to use and provide default-catalog by camilamacedo86 · Pull Request #1675 · operator-framework/operator-controller


		.PHONY: kind-deploy
		kind-deploy: export MANIFEST := ./operator-controller.yaml
		kind-deploy: export DEFAULT_CATALOG := ./catalogd/config/base/default/clustercatalogs/default-catalogs.yaml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I change this file, I want to test it out.
So, we cannot use the release one.
Otherwise, we would only get issues related to changes on this file after we do a release


		.PHONY: quickstart
		quickstart: export MANIFEST := https://github.com/operator-framework/operator-controller/releases/download/$(VERSION)/operator-controller.yaml
		quickstart: export DEFAULT_CATALOG := "https://github.com/operator-framework/operator-controller/releases/download/$(VERSION)/default-catalogs.yaml"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use the default catalog YAML released as part of the assets: See:

 $ cat install.sh 
#!/bin/bash
set -euo pipefail
IFS=$'\n\t'

olmv1_manifest=https://github.com/operator-framework/operator-controller/releases/download/v1.2.0-rc1-8-g130cb8e/operator-controller.yaml

if [[ -z "$olmv1_manifest" ]]; then
    echo "Error: Missing required MANIFEST variable"
    exit 1
fi

default_catalogs_manifest="https://github.com/operator-framework/operator-controller/releases/download/v1.2.0-rc1-8-g130cb8e/default-catalogs.yaml"
cert_mgr_version=v1.15.3
install_default_catalogs=true

		disable: '{{ ne .Env.ENABLE_RELEASE_PIPELINE "true" }}'
		extra_files:
		- glob: 'operator-controller.yaml'
		- glob: './catalogd/config/base/default/clustercatalogs/default-catalogs.yaml'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add the asset when we do a release

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (3998a3b) to head (130cb8e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1675   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files          57       57           
  Lines        4619     4619           
=======================================
  Hits         3113     3113           
  Misses       1279     1279           
  Partials      227      227

Flag	Coverage Δ
e2e	`53.23% <ø> (-0.09%)`	⬇️
unit	`54.25% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

Jan 30, 2025