🌱 updated macos-specific brew installs to include coreutils for mktemp package by grokspawn · Pull Request #1738 · operator-framework/operator-controller
Description
Reviewer Checklist
- API Go Documentation
- Tests: Unit Tests (and E2E Tests, if appropriate)
- Comprehensive Commit Messages
- Links to related GitHub Issue(s)
…package Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 68.24%. Comparing base (
4a007b0) to head (01205bc).
Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1738 +/- ## ======================================= Coverage 68.24% 68.24% ======================================= Files 58 58 Lines 4988 4988 ======================================= Hits 3404 3404 Misses 1342 1342 Partials 242 242
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 52.92% <ø> (ø) |
|
| unit | 55.45% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
|
|
||
| ```sh | ||
| brew install bash gnu-tar gsed | ||
| brew install bash gnu-tar gsed coreutils |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that could sort out my scenario as well 👍
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so, and I was trying to make use of your "fresh eyes" here to spot where we could fix any gaps (#1733 (comment)).
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters