Home Original page

:seedling: Tidy up Makefile and remove convert-diff GHA by perdasilva · Pull Request #1900 · operator-framework/operator-controller

Conversation

@perdasilva

Description

Tidies up the Makefile by combining the bundle manifest generation recipe with verify.

We also remove the convert-diff GHA in favor or running the test in the verify GHA

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@netlify

joelanford

Comment on lines +401 to +411

build-docs:
. $(VENV)/activate; \
mkdocs build

.PHONY: serve-docs
serve-docs: venv
serve-docs:
. $(VENV)/activate; \
mkdocs serve

.PHONY: deploy-docs
deploy-docs: venv
deploy-docs:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad - ide was complaining so I thought they were left over from a few months back when there was some makefile refactoring. I've put them back in.

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.21%. Comparing base (3bc7496) to head (144e8d9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   69.27%   69.21%   -0.06%     
==========================================
  Files          67       67              
  Lines        5302     5302              
==========================================
- Hits         3673     3670       -3     
- Misses       1397     1399       +2     
- Partials      232      233       +1
Flag Coverage Δ
e2e 50.49% <ø> (-0.08%) ⬇️
unit 57.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

joelanford

Merged via the queue into operator-framework:main with commit 115a122

Apr 4, 2025

18 of 19 checks passed

2 participants

@perdasilva @joelanford