Home Original page

✨ Log catalogd feature gate states by bentito · Pull Request #1930 · operator-framework/operator-controller

@bentito

Description

As a followup to #1858 and working from #1922 we add similar logging to the catalogd side of things.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@bentito

@netlify

@codecov

@tmshort

Is this already done in op-con? If if so, why isn't there shared code?

@bentito

Is this already done in op-con? If if so, why isn't there shared code?

Oh hmm, because I didn't think of it. Let me see if we can change to share the code.

@bentito 

Signed-off-by: Brett Tofel <btofel@redhat.com>

@bentito

@tmshort, moved the feature logging func to a central locale and added a test just to make sure we're getting out what we want and honoring sorting. PTAL again.

tmshort

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tmshort tmshort added this pull request to the merge queue

Apr 23, 2025

Merged via the queue into operator-framework:main with commit e3be328

Apr 23, 2025

20 checks passed