Home Original page

:seedling: Make target namespaces optional by perdasilva · Pull Request #1945 · operator-framework/operator-controller

Conversation

@perdasilva

Description

This PR updates the BundleRenderer's Render method signature by removing the targetNamespaces parameter as a required parameter in favor of making it an option. It also adds additional unit tests around options and fixes an NPE caused by passing nil as the options parameter.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

@netlify

thetechnick

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (1171691) to head (c603c5f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
+ Coverage   66.67%   66.77%   +0.09%     
==========================================
  Files          75       75              
  Lines        6326     6335       +9     
==========================================
+ Hits         4218     4230      +12     
+ Misses       1843     1841       -2     
+ Partials      265      264       -1
Flag Coverage Δ
e2e 45.21% <71.42%> (+0.08%) ⬆️
unit 56.36% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into operator-framework:main with commit 9ffc0d4

Apr 30, 2025

20 checks passed

2 participants

@perdasilva @thetechnick