✨OPRUN-3873: Add e2e tests for NetworkPolicies by anik120 · Pull Request #2013 · operator-framework/operator-controller

Hi @anik120

I see that you asked for their input here as well; #2013 (comment), so we can wait for their thoughts

However, IHMO:

  • Yes, it would be better to do the tests by checking the YAML files directly, as discussed yesterday
  • However, IMHO:

Yes — it would indeed be better to write the tests by checking the YAML files directly, as we discussed yesterday. That said, the current implementation is already acceptable. Also, considering our earlier conversation, we’ll likely have the YAML merged in the repo in the future, so an update would be necessary at that point anyway if we want to move toward the ideal approach.

So, IHMO: it’s really up to you. If you’re able to make the change now, that would be great 🥇 — but if not, I think this PR still accomplishes its goal effectively. From my side, LGTM.