🌱 Makefile: add test-upgrade-experimental-e2e by joelanford · Pull Request #2151 · operator-framework/operator-controller
Conversation
Description
Adds a make task and github workflow for running upgrade tests against the experimental e2e release. The intent is for this to be an "informing" job pre-merge, not a blocking job.
Reviewer Checklist
- API Go Documentation
- Tests: Unit Tests (and E2E Tests, if appropriate)
- Comprehensive Commit Messages
- Links to related GitHub Issue(s)
| CATALOGS_MANIFEST := ./manifests/default-catalogs.yaml | ||
|
|
||
| # Manifest used by kind-deploy, which may be overridden by other targets | ||
| SOURCE_MANIFEST := $(STANDARD_MANIFEST) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this is likely breaking things in multiple places (there are a number of failures)
| $(CONTAINER_RUNTIME) save $(CATD_IMG) | $(KIND) load image-archive /dev/stdin --name $(KIND_CLUSTER_NAME) | ||
|
|
||
| .PHONY: kind-deploy | ||
| kind-deploy: export MANIFEST := $(STANDARD_RELEASE_MANIFEST) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting this causes two issues:
- You are redirecting into nothing on L331
- The
envsubstcommand doesn't have a value on L333
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not appear to be carried over from setting it in test-upgrade-e2e, etc.
Yeah, the "experimental-e2e" is using the standard manifest... which is plainly wrong...
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.73%. Comparing base (0e0e706) to head (1e615d8).
⚠️ Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #2151 +/- ## ========================================== - Coverage 72.79% 72.73% -0.06% ========================================== Files 79 79 Lines 7340 7340 ========================================== - Hits 5343 5339 -4 - Misses 1651 1654 +3 - Partials 346 347 +1
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 44.38% <ø> (ø) |
|
| experimental-e2e | 55.00% <ø> (+0.04%) |
⬆️ |
| unit | 58.22% <ø> (-0.02%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Ok, I think I have it fixed up. Will double check that the correct manifests are being used for each job...
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tmshort
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:OWNERS[tmshort]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
openshift-ci
bot
added
the
approved
label
Aug 15, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters