⚠ OPRUN-4106: remove support for annotation based config by anik120 · Pull Request #2224

⚠ OPRUN-4106: remove support for annotation based config by anik120 · Pull Request #2224 · operator-framework/operator-controller

Description

With #2166 and #2163 in place, annotation based config support can be removed.

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.20%. Comparing base (27b05e7) to head (53b0f1a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2224      +/-   ##
==========================================
+ Coverage   72.17%   72.20%   +0.02%     
==========================================
  Files          85       85              
  Lines        8407     8405       -2     
==========================================
+ Hits         6068     6069       +1     
+ Misses       1939     1937       -2     
+ Partials      400      399       -1

Flag	Coverage Δ
e2e	`39.21% <ø> (+0.08%)`	⬆️
experimental-e2e	`46.21% <ø> (+0.06%)`	⬆️
unit	`57.00% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

		namespace: argocd-system
		serviceAccount:
		name: argocd-installer
		config:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some more nuance now with the defaults configuration. Depending on the install modes supported, we'd have different behaviors here. E.g. if the bundle only supports OwnNamespace, you wouldn't specify the watchNamespace. Have you checked the demos still work?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I've made a few extra changes and put them in a separate commit 53b0f1a, demos work perfectly now.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~docs/draft/OWNERS~~ [perdasilva]
~~hack/OWNERS~~ [perdasilva]
~~internal/operator-controller/OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved

Indicates a PR has been approved by an approver from all required OWNERS files.

label

Sep 17, 2025