:bug: add rollingUpdate strategy by jianzhangbjz · Pull Request #2263

:bug: add rollingUpdate strategy by jianzhangbjz · Pull Request #2263 · operator-framework/operator-controller

Description

To address the issue: the cluster operator olm Available=False when cluster upgrading.
I have tested this solution in openshift/operator-framework-operator-controller#515, and it works.

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

https://github.com/operator-framework/operator-controller/actions/runs/18452353047/job/52567797659?pr=2263 failed at:

    cluster_extension_install_test.go:1052: By eventually reporting Progressing == True with Reason Retrying
    cluster_extension_install_test.go:1053: 
        	Error Trace:	/home/runner/work/operator-controller/operator-controller/test/e2e/cluster_extension_install_test.go:1058
        	            				/opt/hostedtoolcache/go/1.24.4/x64/src/runtime/asm_amd64.s:1700
        	Error:      	Not equal: 
        	            	expected: "Retrying"
        	            	actual  : "RolloutInProgress"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-Retrying
        	            	+RolloutInProgress
    cluster_extension_install_test.go:1053: 
        	Error Trace:	/home/runner/work/operator-controller/operator-controller/test/e2e/cluster_extension_install_test.go:1053
        	Error:      	Condition never satisfied
        	Test:       	TestClusterExtensionRecoversFromExistingDeploymentWhenFailureFixed

Signed-off-by: Jian Zhang <jiazha@redhat.com>

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (95c5934) to head (9e5978e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2263   +/-   ##
=======================================
  Coverage   72.87%   72.87%           
=======================================
  Files          88       88           
  Lines        8733     8733           
=======================================
  Hits         6364     6364           
  Misses       1955     1955           
  Partials      414      414

Flag	Coverage Δ
e2e	`39.29% <ø> (+0.03%)`	⬆️
experimental-e2e	`46.31% <ø> (ø)`
unit	`57.99% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~helm/OWNERS~~ [tmshort]
~~manifests/OWNERS~~ [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved

Indicates a PR has been approved by an approver from all required OWNERS files.

label

Oct 13, 2025

Fix included in accepted release 4.21.0-0.nightly-2025-10-15-101012

This was referenced

Dec 1, 2025