[FSSDK-10316] crypto and text encoder polyfill addition for React native by junaed-optimizely · Pull Request #936 · optimizely/javascript-sdk

[FSSDK-10316] crypto and text encoder polyfill addition for React native by junaed-optimizely · Pull Request #936 · optimizely/javascript-sdk

Skip to content

Merged

junaed-optimizely merged 4 commits intomasterfrom

junaed/fssdk-10316

Jun 28, 2024

Merged

[FSSDK-10316] crypto and text encoder polyfill addition for React native#936
junaed-optimizely merged 4 commits intomasterfrom
junaed/fssdk-10316

Conversation

Copy link Copy Markdown

Contributor

junaed-optimizely commented
Jun 27, 2024

Summary

crypto module is not supported by React native. Our SDK currently throws "crypto.getRandomValues() not available" error. A polyfill has been added to avoid that issue.
Hermes (React native: JS engine) did not have TextEncoder support until recently. A polyfill has been added for react-native <= 0.73

Test plan

Modified existing React Native test to adjust with the current changes. Existing test should pass

Issues

[FSSDK-10316] crypto and text encoder polyfill addition for React native

junaed-optimizely requested a review from a team as a code owner

June 27, 2024 15:18

optimizely-codereview-bot assigned junaed-optimizely

dev dep update for test cases

Copy link Copy Markdown

coveralls commented
Jun 27, 2024

coverage: 90.307%. remained the same
when pulling ff8c3c2 on junaed/fssdk-10316
into 4909efb on master.

dependency version fix

Copy link Copy Markdown

coveralls commented
Jun 27, 2024

coverage: 90.307%. remained the same
when pulling bf50567 on junaed/fssdk-10316
into 4909efb on master.

mikechu-optimizely approved these changes Jun 28, 2024

View reviewed changes

Copy link Copy Markdown

Contributor

mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some nit but LGTM. Thanks for const+let

Comment thread

__mocks__/fast-text-encoding.ts

Comment thread

__mocks__/react-native-get-random-values.ts Outdated

Copy link Copy Markdown

coveralls commented
Jun 28, 2024

coverage: 90.307%. remained the same
when pulling e0170f3 on junaed/fssdk-10316
into 4909efb on master.

junaed-optimizely merged commit 46e2ab4 into master

junaed-optimizely deleted the junaed/fssdk-10316 branch

June 28, 2024 14:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants