[FSSDK-10464] update import for uuid by raju-opti · Pull Request #961 · optimizely/javascript-sdk

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@raju-opti

Copy link Copy Markdown

Contributor

@raju-opti raju-opti commented

Nov 15, 2024

edited

Loading

Summary

  • update the way uuid module is used cause it was causing issues for some clients

Test plan

  • all existing tests should pass

Issues

  • FSSDK-10464

@coveralls

Copy link Copy Markdown

coveralls commented

Nov 15, 2024

edited

Loading

Coverage Status

coverage: 96.982%. remained the same
when pulling 9fcee71 on raju/uuid-v4
into 16cda94 on 4.x.x.

Copy link Copy Markdown

Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit bfcdc49 into 4.x.x

Nov 18, 2024

@raju-opti raju-opti deleted the raju/uuid-v4 branch

November 18, 2024 12:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@junaed-optimizely junaed-optimizely Awaiting requested review from junaed-optimizely

Assignees

@raju-opti raju-opti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raju-opti @coveralls @jaeopt @mikechu-optimizely