[FSSDK-11098] prep for release by junaed-optimizely · Pull Request #996 · optimizely/javascript-sdk
Navigation Menu
{{ message }}
optimizely / javascript-sdk Public
- Notifications You must be signed in to change notification settings
- Fork 87
Merged
[FSSDK-11098] prep for release#996
junaed-optimizely merged 2 commits into5.x.xfrom
[FSSDK-11098] prep for release#996
junaed-optimizely merged 2 commits into5.x.xfrom
Conversation
Copy link Copy Markdown
Contributor
junaed-optimizely
commented
Jan 29, 2025
junaed-optimizely
commented
Summary
Test plan
Existing tests should pass
Issues
junaed-optimizely
requested a review
from raju-opti
Copy link Copy Markdown
raju-opti reviewed Jan 29, 2025
|
|
||
| ### Bug Fixes | ||
|
|
||
| - Using `optimizely.readyPromise` instead of `optimizely.onReady` to avoid setTimeout call in edge environments. ([#995](https://github.com/optimizely/javascript-sdk/pull/995)) |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add the Rolloup experiment fix here as well
raju-opti approved these changes Jan 29, 2025
Copy link Copy Markdown
Contributor
raju-opti
left a comment
raju-opti
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. one comment
junaed-optimizely
merged commit
90ef0d7
into
5.x.x
junaed-optimizely
deleted the
junaed/prepare-5.3.5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants