Ensure HTTP status code is not lost when catching exception by jonesbusy · Pull Request #550 · oras-project/oras-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jonesbusy

Copy link

Collaborator

@jonesbusy jonesbusy commented

Feb 16, 2026

edited

Loading

Description

Ensure HTTP status code is not lost when catching exception

Testing done

Added one test

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@jonesbusy jonesbusy force-pushed the feature/test-cleanup-1 branch from 7771b6d to 80e9eda Compare

February 16, 2026 11:00

@codecov

Copy link

codecov bot commented

Feb 16, 2026

edited

Loading

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.39%. Comparing base (e652f07) to head (1bcd75e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/auth/HttpClient.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #550      +/-   ##
============================================
+ Coverage     87.57%   88.39%   +0.82%     
- Complexity      768      771       +3     
============================================
  Files            42       42              
  Lines          2253     2258       +5     
  Branches        277      278       +1     
============================================
+ Hits           1973     1996      +23     
+ Misses          169      153      -16     
+ Partials        111      109       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy force-pushed the feature/test-cleanup-1 branch from 80e9eda to a78327c Compare

February 16, 2026 12:11

@jonesbusy jonesbusy changed the title Some test code cleanup Ensure HTTP status code is not lost when catching exception

Feb 16, 2026

@jonesbusy jonesbusy force-pushed the feature/test-cleanup-1 branch from a78327c to 8e3d94c Compare

February 16, 2026 12:21

@jonesbusy jonesbusy marked this pull request as ready for review

February 16, 2026 12:23

@jonesbusy jonesbusy force-pushed the feature/test-cleanup-1 branch from 8e3d94c to a533c6b Compare

February 16, 2026 13:09
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>

@jonesbusy jonesbusy force-pushed the feature/test-cleanup-1 branch from a533c6b to 1bcd75e Compare

February 16, 2026 13:21

@jonesbusy jonesbusy merged commit ba1238e into oras-project:main

Feb 16, 2026

8 checks passed

@jonesbusy jonesbusy deleted the feature/test-cleanup-1 branch

February 16, 2026 13:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonesbusy