Only try to parse Error if we get JSON content type by jonesbusy · Pull Request #555 · oras-project/oras-java
Conversation
Description
Only try to parse Error if we get JSON content type.
Avoid populing the logs with JSON parse issue
Testing done
None in particular
Submitter checklist
- I have read and understood the CONTRIBUTING guide
- I have run
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.35%. Comparing base (9da20f4) to head (eaa6910).
⚠️ Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #555 +/- ## ============================================ + Coverage 87.60% 88.35% +0.75% - Complexity 784 786 +2 ============================================ Files 42 42 Lines 2324 2328 +4 Branches 288 289 +1 ============================================ + Hits 2036 2057 +21 + Misses 175 159 -16 + Partials 113 112 -1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
jonesbusy
deleted the
feature/do-not-attempt-deserilize-non-json
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters