Fix `getEffectiveRegistry` to return registry only by jonesbusy · Pull Request #569 · oras-project/oras-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jonesbusy

Copy link

Collaborator

@jonesbusy jonesbusy commented

Feb 19, 2026

edited

Loading

Description

Fix getEffectiveRegistry to return registry only

Testing done

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@jonesbusy jonesbusy force-pushed the feature/cleanu-fix-alias branch from 1c43786 to e52f3fc Compare

February 19, 2026 08:36

@codecov

Copy link

codecov bot commented

Feb 19, 2026

edited

Loading

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.43%. Comparing base (aa9834d) to head (834074e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/auth/RegistriesConf.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #569      +/-   ##
============================================
+ Coverage     88.04%   88.43%   +0.39%     
+ Complexity      803      800       -3     
============================================
  Files            42       42              
  Lines          2383     2386       +3     
  Branches        292      292              
============================================
+ Hits           2098     2110      +12     
+ Misses          173      162      -11     
- Partials        112      114       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>

@jonesbusy jonesbusy force-pushed the feature/cleanu-fix-alias branch from e52f3fc to 834074e Compare

February 19, 2026 08:43

@jonesbusy jonesbusy changed the title Check alias before rewrite Fix getEffectiveRegistry to return registry only

Feb 19, 2026

@jonesbusy jonesbusy self-assigned this

Feb 19, 2026

@jonesbusy jonesbusy added the bug

Something isn't working

label

Feb 19, 2026

@jonesbusy jonesbusy marked this pull request as ready for review

February 19, 2026 08:47

@jonesbusy jonesbusy merged commit 2c8acfc into oras-project:main

Feb 19, 2026

8 checks passed

@jonesbusy jonesbusy deleted the feature/cleanu-fix-alias branch

February 19, 2026 08:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jonesbusy jonesbusy

Labels

bug

Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonesbusy