Slicing QuerySet Result Objects by SepehrBazyar · Pull Request #765 · ormar-orm/ormar
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 96
Open
SepehrBazyar wants to merge 23 commits intoormar-orm:masterfrom
Open
Slicing QuerySet Result Objects#765
SepehrBazyar wants to merge 23 commits intoormar-orm:masterfrom
Slicing QuerySet Result Objects#765
SepehrBazyar wants to merge 23 commits intoormar-orm:masterfrom
Conversation
SepehrBazyar added 7 commits
July 28, 2022 19:48Copy link
Codecov Report
Merging #765 (8a8186e) into master (e923513) will not change coverage.
The diff coverage is100.00%.
@@ Coverage Diff @@ ## master #765 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 192 192 Lines 16057 16140 +83 ========================================= + Hits 16057 16140 +83
| Impacted Files | Coverage Δ | |
|---|---|---|
| ormar/queryset/queryset.py | 100.00% <100.00%> (ø) |
|
| ormar/queryset/utils.py | 100.00% <100.00%> (ø) |
|
| ormar/relations/querysetproxy.py | 100.00% <100.00%> (ø) |
|
| tests/test_queries/test_pagination.py | 100.00% <100.00%> (ø) |
collerek and others added 7 commits
July 29, 2022 17:23Copy link
Contributor Author
SepehrBazyar
commented
Aug 5, 2022
SepehrBazyar commented
Aug 5, 2022Hi @collerek
Thank you, please, if you do the review.
collerek added 2 commits
August 5, 2022 10:48Copy link
Collaborator
collerek
commented
Aug 25, 2022
collerek commented
Aug 25, 2022What about slicing also the querysetproxy to allow slicing the related models?
SepehrBazyar added 6 commits
August 26, 2022 23:55…yar/ormar into slice_getitem_queryset
SepehrBazyar
force-pushed
the
slice_getitem_queryset
branch
from
5d5cfab to
7330d56
Compare
Copy link
Contributor Author
SepehrBazyar
commented
Sep 13, 2022
SepehrBazyar commented
Sep 13, 2022@collerek
Were these changes desirable and correct?
Copy link
Contributor Author
SepehrBazyar
commented
Mar 27, 2023
SepehrBazyar commented
Mar 27, 2023This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment