Slicing QuerySet Result Objects by SepehrBazyar · Pull Request #765 · ormar-orm/ormar

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@SepehrBazyar

Copy link

Contributor

No description provided.

@codecov-commenter

Copy link

codecov-commenter commented

Jul 28, 2022

edited

Loading

Codecov Report

Merging #765 (8a8186e) into master (e923513) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #765   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        16057     16140   +83     
=========================================
+ Hits         16057     16140   +83     
Impacted Files Coverage Δ
ormar/queryset/queryset.py 100.00% <100.00%> (ø)
ormar/queryset/utils.py 100.00% <100.00%> (ø)
ormar/relations/querysetproxy.py 100.00% <100.00%> (ø)
tests/test_queries/test_pagination.py 100.00% <100.00%> (ø)

@SepehrBazyar

Copy link

Contributor Author

Hi @collerek
Thank you, please, if you do the review.

@collerek

Copy link

Collaborator

What about slicing also the querysetproxy to allow slicing the related models?

SepehrBazyar reacted with thumbs up emoji

@SepehrBazyar SepehrBazyar force-pushed the slice_getitem_queryset branch from 5d5cfab to 7330d56 Compare

August 27, 2022 11:53

@SepehrBazyar

Copy link

Contributor Author

@collerek
Were these changes desirable and correct?

@SepehrBazyar

Copy link

Contributor Author

@collerek Were these changes desirable and correct?

@collerek Do I need to make another change for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SepehrBazyar @codecov-commenter @collerek