Fixes in windows helpers by zwass · Pull Request #8549 · osquery/osquery
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 2.6k
Merged
directionless merged 1 commit intoosquery:masterfrom
Feb 19, 2025Merged
directionless merged 1 commit intoosquery:masterfrom
directionless merged 1 commit intoosquery:masterfrom
Conversation
Copy link
Member
zwass
commented
Feb 18, 2025
zwass
commented
- Fix a memory leak in getGroupSidFromUsername (leaked the allocated Sid buffer)
- Improve Unicode support in psidToString by moving to ConvertSidToStringW
- Fix a memory leak in getGroupSidFromUsername (leaked the allocated Sid buffer) - Improve Unicode support in psidToString by moving to ConvertSidToStringW
zwass
requested review from
a team
as code owners
zwass
added
bug
Windows
labels
Smjert approved these changes Feb 18, 2025
Copy link
Member
Smjert
left a comment
Smjert
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment