Feat/ffi provider by elliottmurray · Pull Request #245 · pact-foundation/pact-python
Draft PR for FFI Provider work
| elif 'linux' in target_platform: | ||
| libname = "./libpact_ffi-linux-x86_64.so" | ||
| elif 'windows' in target_platform: | ||
| libname = "libpact_ffi-osx-x86_64.dylib" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be .dll for Windows
| if 'windows' in platform.platform().lower(): | ||
| fetch_lib(bin_path, suffix, 'dll') | ||
| fetch_lib(bin_path, suffix, 'dll.lib') | ||
| fetch_lib(bin_path, suffix, 'lib') |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are using the DLL, you don't need the static lib (.lib). But there is no harm in downloading it, apart from it being the biggest one.
…e changes to docker37 which I will need to do to all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters