Add an optional current_item parameter to ProgressBar.update() by thecav · Pull Request #1332 · pallets/click
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
davidism merged 1 commit intopallets:masterfrom
Aug 1, 2019Merged
Add an optional current_item parameter to ProgressBar.update()#1332
davidism merged 1 commit intopallets:masterfrom
Add an optional current_item parameter to ProgressBar.update()#1332
davidism merged 1 commit intopallets:masterfrom
Conversation
Copy link
Contributor
thecav
commented
May 31, 2019
thecav
commented
Fix #1226 Add an optional current_item parameter to ProgressBar.update() to allow for item_show_func to continue to display when using update(). A usage example for this was added to ProgressBar and some new tests.
Copy link
Contributor
jcrotts
commented
May 31, 2019
jcrotts commented
May 31, 2019Could you add an entry to the changelog, and a version added marker to the new docs you added. Thanks for the PR.
Copy link
Contributor Author
thecav
commented
Jun 2, 2019
thecav commented
Jun 2, 2019Sure, would this go under the unreleased 7.1 section?
Copy link
Contributor
jcrotts
commented
Jun 2, 2019
jcrotts commented
Jun 2, 2019David may say otherwise but since this is a new feature it will probably go under 8.0 unreleased. 7.1 is for bugs and docs changes.
thecav
force-pushed
the
update-current-item
branch
from
b38a826 to
61b40f5
Compare
davidism
added this to the
8.0 milestone
thecav
force-pushed
the
update-current-item
branch
from
61b40f5 to
7592de8
Compare
davidism
force-pushed
the
update-current-item
branch
from
7592de8 to
cdd0080
Compare
This allows updating what item is displayed when using ProgressBar.update to control the exact progress.
davidism
force-pushed
the
update-current-item
branch
from
cdd0080 to
04a17ae
Compare
davidism
merged commit
716a5be
into
pallets:master
github-actions
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants