Correct click.edit typing by AndreasBackx · Pull Request #2804 · pallets/click
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Conversation
The following typing issues existed before:
click.edit- The
textargument acceptedbytearraybut was not included in the typing.
- The
_termui_impl- If
Nonewas inputted,strwould be returned but typing suggested that it would bestrifstrwas given andbytesifbyteswas given.
- If
This resolved an type: ignore as well.
Add tests that demonstrate the correct behavior of the change. Tests
should fail without the change.Add or update relevant docs, in the docs folder and in code.Add an entry in CHANGES.rst summarizing the change and linking to the issue.- Not going to add an entry because
bytearraywas always accepted, just not documented.
- Not going to add an entry because
Add.. versionchanged::entries in any relevant code docs.
github-actions
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters