refactor: removed unused and unnecessary dependencies by mfranzke · Pull Request #1396 · pattern-lab/patternlab-node
Navigation Menu
{{ message }}
pattern-lab / patternlab-node Public
- Notifications You must be signed in to change notification settings
- Fork 399
Merged
JosefBredereck merged 4 commits intopattern-lab:devfrom
Dec 30, 2021Merged
refactor: removed unused and unnecessary dependencies#1396
JosefBredereck merged 4 commits intopattern-lab:devfrom
refactor: removed unused and unnecessary dependencies#1396
JosefBredereck merged 4 commits intopattern-lab:devfrom
Conversation
Copy link
Contributor
Summary of changes
Removed the following dependencies, that were either unused or unnecessary:
-
NOTE:
fs.existsSynchas been un-deprecated in Node.js since 6.8.0. If you only need to check synchronously, this module is not needed. -
@pattern-lab/live-serverin@pattern-lab/cli: This package is not used in the cli -
sanitize-filename: This package has been introduced to the cli package with commit a50fb3a, but never been used -
eslint-plugin-import: This plugin doesn't seem to be in use, neither within the code of its introduction commit nor afterwards. -
eslint-config-airbnb-base: This config doesn't seem to be in use, neither within the code of its introduction commit nor afterwards.
mfranzke added 3 commits
December 11, 2021 15:33
mfranzke
marked this pull request as draft
mfranzke
marked this pull request as ready for review
mfranzke
added
the
ready for review
label
mfranzke
requested a review
from JosefBredereck
mfranzke
added
dependencies
fix / refactor 🚧 labels
Dec 27, 2021Copy link
Contributor
JosefBredereck
commented
Dec 30, 2021
JosefBredereck commented
Dec 30, 2021I like that. So we lose some weight 🚀
JosefBredereck approved these changes Dec 30, 2021
JosefBredereck
merged commit
f0e29e9
into
pattern-lab:dev
mfranzke
deleted the
refactor/removed-unused-dependencies
branch
Copy link
Contributor
JosefBredereck
commented
Jan 29, 2022
JosefBredereck commented
Jan 29, 2022PR was released with v5.16.0
JosefBredereck
added
released 🚀
and removed
ready for review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment