fix(engine-twig): twig include function syntax not matched by findPar… by hadl · Pull Request #1473 · pattern-lab/patternlab-node
Navigation Menu
{{ message }}
pattern-lab / patternlab-node Public
- Notifications You must be signed in to change notification settings
- Fork 399
Merged
JosefBredereck merged 2 commits intopattern-lab:devfrom
Jan 30, 2023Merged
Conversation
Copy link
Contributor
hadl
commented
Jan 15, 2023
hadl
commented
Closes: #1471
Summary of changes:
Updated findPartials regex to match twig include function syntax.
In addition the logic from engine-twig-php for findPartials and findPartial was merged to fit the new regex and locating the patterns correctly.
…tials Closes: pattern-lab#1471
JosefBredereck approved these changes Jan 17, 2023
JosefBredereck approved these changes Jan 30, 2023
JosefBredereck
merged commit
cfa792b
into
pattern-lab:dev
hadl
deleted the
feature/1471-twing-include-function-regex
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants