fix: js error by mfranzke · Pull Request #1475 · pattern-lab/patternlab-node
Navigation Menu
{{ message }}
pattern-lab / patternlab-node Public
- Notifications You must be signed in to change notification settings
- Fork 399
Merged
Conversation
Copy link
Contributor
Summary of changes:
There's a JS error due to the change at https://github.com/pattern-lab/patternlab-node/pull/1102/files#diff-9111c2e0138c935342632437be7178f25322b8f5c86431f2b85f4fe760d32980L96-R111 in which a method parameter has been renamed within the file packages/uikit-workshop/src/scripts/components/pl-nav/nav.js, but not within the method references itself.
Renamed the e parameter to event within two other files as well to align and clarify the naming.
mfranzke added 2 commits
January 29, 2023 18:42
mfranzke
added
the
bug 🐛
label
mfranzke
requested a review
from JosefBredereck
mfranzke
self-assigned this
mfranzke
requested a review
from sghoweri
as a code owner
JosefBredereck approved these changes Jan 30, 2023
JosefBredereck
merged commit
209b9a1
into
dev
JosefBredereck
deleted the
fix-js-error
branch
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request
Apr 12, 2023* fix: js error that was introduced with https://github.com/pattern-lab/patternlab-node/pull/1102/files#diff-9111c2e0138c935342632437be7178f25322b8f5c86431f2b85f4fe760d32980L96-R111 * chore: aligned naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment