feat(SimpleFileUpload): consumed Penta updates by thatblindgeye · Pull Request #10026

feat(SimpleFileUpload): consumed Penta updates by thatblindgeye · Pull Request #10026 · patternfly/patternfly-react

Conversation

Eric Olkowski added 4 commits

January 18, 2024 15:39

		</InputGroupItem>
		<InputGroupItem>
		<Button
		id={`${id}-browse-button`}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could keep this in, but if we're going to expose an ID on the browse button then we should consider allowing an ID to be passed to all other input elements within the component. For now I included this in the codemod issue patternfly/pf-codemods#551

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a codemod, right? To deal with the helper text change?

@nicolethoen good point. I updated codemod patternfly/pf-codemods#551 to mention providing a warning that consumers should use the new FileUploadHelperText sub-component (right now we only have examples that show using a FormHelperText as a separate piece).